Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marianfoo: Week1/Week2/Week3 #7

Closed
wants to merge 5 commits into from
Closed

marianfoo: Week1/Week2/Week3 #7

wants to merge 5 commits into from

Conversation

marianfoo
Copy link

No description provided.

@nicoschoenteich
Copy link
Contributor

nicoschoenteich commented Jun 8, 2022 •
edited
Loading

The workflow says the same thing ✅
Congrats on being the first person to submit 🎉
More tests will be added in the coming weeks 🤙

@marianfoo
Copy link
Author

Looking forward :)

@marianfoo
Copy link
Author

@nicogeburek
Hi Nico,
is it intentional that the workflow must always be released by you?
Is a bit annoying to always wait for it and you have more effort.
Or is it predefined by the SAP organization?

@nicoschoenteich
Copy link
Contributor

Hi @marianfoo, many thanks for your submissions. The approval flow is actually defined by GitHub, not much we can do about it... 😕

@marianfoo marianfoo changed the title Minimal App to pass tests marianfoo: Week1/Week2 Jun 15, 2022
@marianfoo marianfoo changed the title marianfoo: Week1/Week2 marianfoo: Week1/Week2/Week3 Jun 23, 2022
@marianfoo marianfoo closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoschoenteich nicoschoenteich nicoschoenteich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marianfoo @nicoschoenteich