You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I now got a first working version of a Github Action Workflow that uses ABAP Cleaner 😄.
As I am not a GitHub Workflow expert by far, I am not sure if it is the best approach to do it, but hey, it is working.
Here is the workflow in my sample repository. I only had one minor hickup after the job first ran and I tried to import the changes back into my ABAP system.
After a little bit of debugging I found the culprit... crlf 😋. abapGit is splitting the received text content from git at lf into an internal table. The left behind carriage return is then seen as unknown statement and the import fails.
In a local setup the crlf characters written by ABAP cleaner never caused this because of the git setting core.autocrlf = true. And luckily enough this can also be set inside the workflow. So an additional step before the checkout solved it.
that's amazing!! Hardly any GitHub Workflow knowledge on my side, but could you try changing the hard-coded release number into this: releases/download/v1.6.0/ -> releases/latest/download/
the How to use ABAP cleaner documentation was now enhanced with a section on GitHub Actions workflow usage! Hope this is as you expected it to be – otherwise please let me know. And again thanks so much for you contributions!
Hi Jörg-Michael,
I now got a first working version of a Github Action Workflow that uses ABAP Cleaner 😄.
As I am not a GitHub Workflow expert by far, I am not sure if it is the best approach to do it, but hey, it is working.
Here is the workflow in my sample repository. I only had one minor hickup after the job first ran and I tried to import the changes back into my ABAP system.
After a little bit of debugging I found the culprit...
crlf
😋. abapGit is splitting the received text content from git atlf
into an internal table. The left behind carriage return is then seen as unknown statement and the import fails.In a local setup the
crlf
characters written by ABAP cleaner never caused this because of the git settingcore.autocrlf = true
. And luckily enough this can also be set inside the workflow. So an additional step before the checkout solved it.After that additional file changes via the workflow could be imported back to the ABAP system without any issue.
All the best,
Ludwig
The text was updated successfully, but these errors were encountered: