New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad result of Align SORT command ( stand alone cleaner in WINDOWS) #141
Comments
Hi Thomas, thanks a lot for this example! You're right, of course – I shall look into this! I guess the expected result would be SORT: gt_vbep_before BY vbeln
posnr
edatu,
gt_vbep_after BY edatu. so all components are aligned, even if the table names have different length. Kind regards, |
Hi Jörg-Michael Yes that would be the result I prefere, but I am no clean-code expert. I think maybe other people would prefere this result:
Regards Thomas |
naa - I ment this result:
|
Hi Thomas, I now enhanced this cleanup rule to consider SORT: chains as well: Note that still only the component lists are aligned, keeping the BY keywords where they are – aligned or unaligned – because with the additions STABLE, ASCENDING/DESCENDING, AS TEXT after the table name, aligning "BY" might create huge gaps: To align everything, we'd need more options to configure what that should look like. Kind regards, |
Hi Thomas, thanks again for reporting this bug – this should now be fixed in version 1.7.2, which was just released. Kind regards, |
Before cleaner :
After cleraner:
The text was updated successfully, but these errors were encountered: