Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Clipboard clean-up in the Eclipse plugin #155

Closed
ConjuringCoffee opened this issue Oct 18, 2023 · 7 comments
Closed

Feature request: Clipboard clean-up in the Eclipse plugin #155

ConjuringCoffee opened this issue Oct 18, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@ConjuringCoffee
Copy link
Contributor

ConjuringCoffee commented Oct 18, 2023

Hi Jörg-Michael, cleaning up code stored in the clipboard is only possible using the stand-alone application right now. Would it be possible to include this feature in the Eclipse plugin? In our current SAP system release, there are still some development objects (e.g. enhancements) where the ADT editor can't be used yet. I'd like to be able to copy code from SAP GUI to my clipboard, use the ABAP Cleaner, then paste it back into SAP GUI.

This use case doesn't really happen that often to warrant keeping the stand-alone application updated in parallel, so I'd like to avoid that. 😉

@jmgrassau jmgrassau added the enhancement New feature or request label Oct 18, 2023
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

that's a nice point – and now that we have this third option …

image

… which is sure to not modify the code in ADT (whatever happens inside the ABAP cleaner UI), why not allow the "From Clipboard" and "From File" menu items from the stand-alone version here, too!

image

I'd only think that "Watch and Modify Clipboard" would be taking things too far. And "Clean Up With Interactive ABAP Cleaner…" should not show any of these 4 menu items, because here, the code in ADT is locked and replaced by the cleanup result.

Kind regards,
Jörg-Michael

@jmgrassau jmgrassau self-assigned this Oct 18, 2023
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

done :-) that was an easy win!

Kind regards,
Jörg-Michael

@ConjuringCoffee
Copy link
Contributor Author

Wow, your speed is impressive! Now let me reward that with an additional feature request... 😇 Would it be possible to make the function available if the active tab is showing the SAP GUI?

The ABAP Cleaner can only be accessed using the menu option "Source code":
image

This section isn't available when the active tab shows the SAP GUI:
image

@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

I forwarded this question to a colleague who'd know better about this, but my feeling is that this won't be possible.

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

and here's version 1.8.0, allowing to paste any ABAP code into the read-only preview! :-) As with the stand-alone version, all code blocks such as IF ... ENDIF must be complete in the pasted code.

I will let you know when I hear news about SAP GUI inside ADT, but closing this for now.

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

thanks for this nice reward ;-)

Wow, your speed is impressive! Now let me reward that with an additional feature request... 😇
Would it be possible to make the function available if the active tab is showing the SAP GUI?

The colleague I asked has confirmed that this is not possible, because ADT has no information on what is shown, selected etc. in the embedded GUI. Therefore, no "Source Code" menu is shown, and there is no way of running ABAP cleaner on the code inside the embedded GUI.

But then, who would want to edit ABAP code in SE80 when they have ADT! :-)

Menu "Source Code" works, of course, if SAP GUI is opened with this option…
image
… and code is then indeed displayed inside of an ADT text editor.

Kind regards,
Jörg-Michael

@ConjuringCoffee
Copy link
Contributor Author

Thanks for the new clipboard feature!

But then, who would want to edit ABAP code in SE80 when they have ADT! :-)

Just to make it clear, this would be required when working in objects in which ADT can't be used yet. Because the "Source Code" menu isn't displayed, you need to navigate to another ADT tab, access the ABAP Cleaner there, and then navigate back to the SAP GUI tab. A little bit cumbersome, but it works 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants