Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong alignment of declarations? #186

Closed
Koch013 opened this issue Nov 8, 2023 · 3 comments
Closed

Wrong alignment of declarations? #186

Koch013 opened this issue Nov 8, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Koch013
Copy link

Koch013 commented Nov 8, 2023

Hi,

for me the alignment of chained declarations using the default action for chains (align name, type, length, value, ...) looks not as expected.

METHOD b.
DATA: gt_mat TYPE STANDARD TABLE OF mara,
      gv_one   TYPE DECFLOAT16 LENGTH 8   DECIMALS 2,
      gv_second  TYPE p LENGTH 8  DECIMALS 0,
      gv_bool TYPE abap_bool.
ENDMETHOD.

will be cleaned to:

  METHOD b.
    DATA: gt_mat    TYPE STANDARD TABLE OF mara,
          gv_one    TYPE decfloat16             LENGTH 8 DECIMALS 2,
          gv_second TYPE p                      LENGTH 8 DECIMALS 0,
          gv_bool   TYPE abap_bool.
  ENDMETHOD.

I think the alignment of LENGTH with the end of the first line doesn't look good.

I hoped more for a cleaned version like the result of this (first line is not in the chain)

method a.
DATA gt_mat TYPE STANDARD TABLE OF mara.
DATA:      gv_one   TYPE DECFLOAT16 LENGTH 8   DECIMALS 2,
      gv_second  TYPE p LENGTH 8  DECIMALS 0,
      gv_bool TYPE abap_bool.     
ENDMETHOD.

Result:


  METHOD a.
    DATA gt_mat TYPE STANDARD TABLE OF mara.
    DATA: gv_one    TYPE decfloat16 LENGTH 8 DECIMALS 2,
          gv_second TYPE p          LENGTH 8 DECIMALS 0,
          gv_bool   TYPE abap_bool.
  ENDMETHOD.

Thanks!

@jmgrassau jmgrassau added the bug Something isn't working label Nov 9, 2023
@jmgrassau
Copy link
Member

Hi,

thanks a lot for this example, absolutely agree, the lengthy "TYPE STANDARD TABLE OF mara" should not influence the width of the entire TYPE column. Will look into this!

Kind regards,
Jörg-Michael

@jmgrassau jmgrassau self-assigned this Nov 13, 2023
@jmgrassau
Copy link
Member

Hi,

this will be fixed with the next release, where TABLE type clauses will not influence the width of the TYPE … column in other declaration lines anymore:

image

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi,

thanks again for reporting this alignment issue – this should now be fixed with version 1.11.1, which was just released!

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants