Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

##Needed is not correct recognized #200

Closed
fmabap opened this issue Nov 16, 2023 · 5 comments
Closed

##Needed is not correct recognized #200

fmabap opened this issue Nov 16, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@fmabap
Copy link

fmabap commented Nov 16, 2023

Hi,
in the following example is ##NEEDED not at the end of the variable declaration.
ABAP-Cleaner set it to the end, but then it does not recognize that it is there and creates a TODO.
Can you please fix it?

image
 METHOD test.

    ##NEEDED data lv_msg type bapi_msg.

    DATA: lv_field TYPE c,
          ##NEEDED lv_msg2 type bapi_msg.

    MESSAGE e001(000) INTO lv_msg.
    MESSAGE e001(000) INTO lv_msg2.

    lv_field = 3.
    WRITE lv_field.
  ENDMETHOD.

Best regards
Frank

@jmgrassau jmgrassau added the bug Something isn't working label Nov 16, 2023
@jmgrassau jmgrassau self-assigned this Nov 16, 2023
@jmgrassau
Copy link
Member

Hi Frank,

you're right, thanks for reporting this! Indeed, this rule so far only considered pragmas at the end (before the comma or period), not at the beginning of the line, although those are correct, too. This will be fixed with the next release!

Kind regards,
Jörg-Michael

@fmabap
Copy link
Author

fmabap commented Nov 16, 2023

Hi Jörg-Michael,
great thank you!

Best regards
Frank

@jmgrassau
Copy link
Member

Hi Frank,

thanks again for opening this issue – this is now fixed with version 1.11.2, which was just released!

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi,

sorry, I entered the wrong issue number in the above commit enable ABAP cleaner menus for WebDynpro implementations – this belongs to issue #220!

Kind regards,
Jörg-Michael

@fmabap
Copy link
Author

fmabap commented Feb 12, 2024

Hi Jörg-Michael,

no problem. Thank you for fixing it. It works in my Testprogramm and also in the productive code.

Kind regards
Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants