Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "measure" by "action" #52

Closed
bjoern-jueliger-sap opened this issue Jun 7, 2023 · 3 comments
Closed

Replace "measure" by "action" #52

bjoern-jueliger-sap opened this issue Jun 7, 2023 · 3 comments
Assignees

Comments

@bjoern-jueliger-sap
Copy link
Member

There's a bunch of places that use "measure" to mean "action" (probably a direct translation of the German Maßnahme), in particular this config UI for the "Delete unused variables" rule:
image

While measure can mean "action" (as in "We've taken measures to clean up our code"), the use of measure to denote a specific repeatable action in the context of a tool like this strikes me as unidiomatic.

(not a pull request because I'd like native speakers' input on this before changing it)

@jmgrassau
Copy link
Member

Hi Björn,

nice one – do you already have a native speaker "at hand" to ask them? If they find more places where wording could be improved, happy to correct them.

Kind regards,
Jörg-Michael

@jmgrassau jmgrassau self-assigned this Jun 10, 2023
@jmgrassau
Copy link
Member

Hi Björn,

I just got confirmation from a native speaker (and computer expert) that "action" is indeed better. Will correct this!

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi Björn,

thanks again, this should now be fixed! As you can see from the bunch of places ;-) link, there are still a few places left, however, those either use "measure" in a different sense (German "messen", rather than "Maßnahme"), or they are keys from the key-value pairs which are persisted to the .cfj profile files. Changing those would be possible, but maybe a bit too much.

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants