"Delete unused variables": TODO comment not removed for exception

[ConjuringCoffee]

Hi Jörg-Michael,

I found an example in which the generated TODO comment is not removed after a use for the variable is added.

Before the variable is used:

  METHOD example.
    TRY.
        RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
      CATCH cx_sy_itab_line_not_found INTO DATA(exception).
*        MESSAGE exception TYPE 'E'.
    ENDTRY.
  ENDMETHOD.

The ABAP Cleaner correctly adds the comment:

  METHOD example.
    TRY.
        RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
      CATCH cx_sy_itab_line_not_found INTO DATA(exception). " TODO: variable is assigned but only used in commented-out code (ABAP cleaner)
*        MESSAGE exception TYPE 'E'.
    ENDTRY.
  ENDMETHOD.

However, actually using the variable afterwards doesn't remove the TODO comment again:

  METHOD example.
    TRY.
        RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
      CATCH cx_sy_itab_line_not_found INTO DATA(exception). " TODO: variable is assigned but only used in commented-out code (ABAP cleaner)
        MESSAGE exception TYPE 'E'.
    ENDTRY.
  ENDMETHOD.

[jmgrassau]

Hi ConjuringCoffee,

very good finding, thanks for reporting this! Hm, maybe the check only works for stand-alone TODO comment lines, not for the special case here? Definitely worth fixing this!

Kind regards,
Jörg-Michael

[jmgrassau]

Hi ConjuringCoffee,

this will be fixed in the next release.

Kind regards,
Jörg-Michael

[jmgrassau]

Hi ConjuringCoffee,

version 1.4.1 was just released and should clean up these line-end comments as well!

Kind regards,
Jörg-Michael