Upload FUGR and suobjects #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huber-nicolas
requested review from
Christopher-Hermann,
albertmink and
schneidermic0
huber-nicolas
commented
Mar 22, 2021
I updated the Readme and deleted the 2 lines with the empty description arrays of parameters and exceptions in the FUNC.json
Christopher-Hermann
requested changes
Mar 22, 2021
schneidermic0
requested changes
Mar 22, 2021
Fix the issues found by Michael and Christopher
albertmink
reviewed
Mar 23, 2021
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "header": { | |||
| "$schema": "http://sap.com/schema/reps.json" | |||
There was a problem hiding this comment.
Suggested change
| "$schema": "http://sap.com/schema/reps.json" | |
| "$schema": "http://github.com/SAP/abap-file-formats/file-formats/fugr/reps.json" |
There was a problem hiding this comment.
I think we have to clarify if we refer to blob/master of the file path as suggested here.
I am very uncertain of how this $schema integrates for possible JSON schema validation or JSON editing with text editors. Technically, it must be a URI, nothing more.
There was a problem hiding this comment.
We will discuss it in the #14
removing spaces in uri formatting the source coding adding descriptions to func components
schneidermic0
requested changes
Mar 23, 2021
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Closed
schneidermic0
requested changes
Mar 24, 2021
Christopher-Hermann
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Title and description has to be adapted to Title-case/sentence-case. But let's do this within #18
schneidermic0
approved these changes
Mar 26, 2021
| }, | ||
| "additionalProperties": false, | ||
| "required": [ | ||
| "includeType" |
There was a problem hiding this comment.
Isn't the header also a required field?
There was a problem hiding this comment.
yes. We will have to change this in all object types schemas.
schneidermic0
requested changes
Mar 26, 2021
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
schneidermic0
approved these changes
Mar 26, 2021
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
albertmink
approved these changes
Mar 31, 2021
remove field "host",
change description of field "client"
add field "activeFunctionExit",
remove following fields from required fields:
"releaseState",
"global",
"exceptionClasses",
"includeNumber",
"notExecutable"
albertmink
added a commit
that referenced
this pull request
Apr 23, 2021
* Upload FUGR and suobjects
* Update Readme and func.json
I updated the Readme and deleted the 2 lines with the empty description arrays of parameters and exceptions in the FUNC.json
* Fix different issues
Fix the issues found by Michael and Christopher
* adapt format.md and fugrtop.reps.json
* replace colon by colon + space
* func: application, client and host are optional
* FUNC: change exception
* Several fixes
removing spaces in uri
formatting the source coding
adding descriptions to func components
* Update file-formats/fugr/examples/lz_aff_example_fugrtop.reps.json
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
* Update file-formats/fugr/examples/saplz_aff_example_fugr.reps.json
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
* Change active to NotExecutable
* change description of "notExecutable"
* func schema group fields
* space after ":"
* Many fixes
* Fix missing "," and space
* Change description of parameter
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
* it is ABAP file formats
* Group rfc fields and change some descriptions
* UXX include not needed
* write global only if true
* change description of "global"
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
* change title and description of "ABAP from Java"
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
* change title and description of "Java from ABAP"
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
* Several changes
remove field "host",
change description of field "client"
add field "activeFunctionExit",
remove following fields from required fields:
"releaseState",
"global",
"exceptionClasses",
"includeNumber",
"notExecutable"
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
Co-authored-by: Albert Mink <albert.mink@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.