Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old hand-written version of NROB and ENHO #132

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Conversation

albertmink
Copy link
Contributor

No description provided.

@albertmink albertmink self-assigned this Jul 20, 2021
Copy link
Contributor

@huber-nicolas huber-nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is ok to remove these two hand-written objects. In the next two-weeks I will upload the automatic generated NROB files.

@albertmink
Copy link
Contributor Author

albertmink commented Jul 21, 2021

All required actions are green, except the one that reports the EDITORCONFIG check results. The EDITORCONFIG checks themselves are green. Restarting the actions does not solve this one.

@larshp
Copy link
Collaborator

larshp commented Jul 21, 2021

I guess its due to configuration? VALIDATE_ALL_CODEBASE: false, so it does not find any files, ie. no status is reported

It should be okay to validate everything every time? I think it will always take a magnitude longer time to download the super-linter docker image, than any actual linting, its just basics for this repo.

https://github.com/SAP/abap-file-formats/blob/amink/rm-old-format/.github/workflows/linter.yml

@albertmink
Copy link
Contributor Author

Agree, we can VALIDATE_ALL_CODEBASE and apply the slim-image provided by the linter https://github.com/github/super-linter/#slim-image

@larshp larshp merged commit 7d01244 into main Jul 21, 2021
@larshp larshp deleted the amink/rm-old-format branch July 21, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest moving not updated file formats to separate/deprecated branch
3 participants