Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPRV] AFF field length extended to match DB fields #594

Merged
merged 8 commits into from
Mar 21, 2024

Conversation

delucapietro
Copy link
Contributor

The field 'namespace' was displayed with only 30 characters while it could be 255 characters long on DB.
In the wizard this namespace can be entered with more characters only when displaying an SPRV in ADT the length is shortened.

delucapietro and others added 2 commits March 18, 2024 16:27
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@wurzka
Copy link
Contributor

wurzka commented Mar 19, 2024

@schneidermic0 could you please double-check? From my point of view, this change should not request an update of the format version.

@schneidermic0
Copy link
Contributor

@schneidermic0 could you please double-check? From my point of view, this change should not request an update of the format version.

https://github.com/SAP/abap-file-formats/blob/main/docs/json.md#incompatible-file-format-changes states, it is an incompatible change if:

Length of a field is extended if some systems cannot store this information

I understand @delucapietro's PR description that the DB can store the length of 255 characters in all releases.

The field 'namespace' was displayed with only 30 characters while it could be 255 characters long on DB.

If so, I would consider it as a compatible change.

@schneidermic0
Copy link
Contributor

The change looks good to me.

@delucapietro Is my assumption above correct?

@delucapietro
Copy link
Contributor Author

@schneidermic0 yes the assumption is correct DB was always in all releases capable of storing the data with 255 characters only the display was shortened by mistake.

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delucapietro Thanks for the update. Looks good to me

@schneidermic0 schneidermic0 merged commit 23986fa into SAP:main Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants