-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPRV] AFF field length extended to match DB fields #594
[SPRV] AFF field length extended to match DB fields #594
Conversation
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@schneidermic0 could you please double-check? From my point of view, this change should not request an update of the format version. |
https://github.com/SAP/abap-file-formats/blob/main/docs/json.md#incompatible-file-format-changes states, it is an incompatible change if:
I understand @delucapietro's PR description that the DB can store the length of 255 characters in all releases.
If so, I would consider it as a compatible change. |
The change looks good to me. @delucapietro Is my assumption above correct? |
@schneidermic0 yes the assumption is correct DB was always in all releases capable of storing the data with 255 characters only the display was shortened by mistake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delucapietro Thanks for the update. Looks good to me
The field 'namespace' was displayed with only 30 characters while it could be 255 characters long on DB.
In the wizard this namespace can be entered with more characters only when displaying an SPRV in ADT the length is shortened.