-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new object type DRAS (abapGit#6950) #622
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @fvalves.
I guess, similar changes should be done for DSFS, as well. Therefor, I wait a minute to not provide the same review. ;)
"! <p class="shorttext">Header</p> | ||
"! Header | ||
"! $required | ||
header TYPE zif_aff_types_v1=>ty_header_60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a short question? Is key-user-tooling supported for DRAS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, If you do not use key-user tooling I suggest to use ty_header_60_cloud
which only supports "standard" and "cloudDevelopmnet"
header TYPE zif_aff_types_v1=>ty_header_60, | |
header TYPE zif_aff_types_v1=>ty_header_60_cloud, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be supported in the future, though. Is it preferable to have it already prepared or should it be restricted now and changed back to ty_header_60
later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to change it and change it back to ty_header_60
as soon as it is supported. As far as I can see this change should be compatible (in the future)
Co-authored-by: Michael Schneider <micha.schneider@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't support key user tooling (yet) I suggest to change the header.
Everything else looks good to me. Thanks for your updates. 👍
"! <p class="shorttext">Header</p> | ||
"! Header | ||
"! $required | ||
header TYPE zif_aff_types_v1=>ty_header_60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, If you do not use key-user tooling I suggest to use ty_header_60_cloud
which only supports "standard" and "cloudDevelopmnet"
header TYPE zif_aff_types_v1=>ty_header_60, | |
header TYPE zif_aff_types_v1=>ty_header_60_cloud, |
@schneidermic0 sorry, I miscommunicated. There aren't any key-user tools yet, but they are supported. |
Added directory for new object type DRAS (abapGit#6950)