[EDCK] Add new object type for EDCK #629
Conversation
|
|
1 similar comment
|
|
There was a problem hiding this comment.
Hi, thank you for the contribution! Do not mind the amount of comments, they are basically all the same. We have some guidelines on how the title and description are written: sentence case for descriptions (only the very first letter is capital) (https://github.com/SAP/abap-file-formats/blob/main/docs/json.md#description)
| TYPES: | ||
| BEGIN OF ty_attributes, | ||
| "! <p class="shorttext">Check Category</p> | ||
| "! Consistency Check Category |
There was a problem hiding this comment.
| "! Consistency Check Category | |
| "! Consistency check category |
| "! $values {@link zif_aff_edck_v1.data:co_check_classification} | ||
| "! $default {@link if_aff_edck_v1.data:co_check_classification.core} | ||
| "! $required | ||
| checkidclassification TYPE ty_check_classification, |
There was a problem hiding this comment.
| checkidclassification TYPE ty_check_classification, | |
| check_id_classification TYPE ty_check_classification, |
| "! $required | ||
| checkcategory TYPE ty_check_category, | ||
| "! <p class="shorttext">Check Classification</p> | ||
| "! Consistency Check ID Classification |
There was a problem hiding this comment.
| "! Consistency Check ID Classification | |
| "! Consistency check ID classification |
| "! $values {@link zif_aff_edck_v1.data:co_check_category} | ||
| "! $default {@link if_aff_edck_v1.data:co_check_category.exist} | ||
| "! $required | ||
| checkcategory TYPE ty_check_category, |
There was a problem hiding this comment.
| checkcategory TYPE ty_check_category, | |
| check_category TYPE ty_check_category, |
| checkidclassification TYPE ty_check_classification, | ||
| "! <p class="shorttext">Additional Check Class</p> | ||
| "! Consistency Check Class | ||
| checkclass TYPE zif_aff_types_v1=>ty_object_name_30, |
There was a problem hiding this comment.
| checkclass TYPE zif_aff_types_v1=>ty_object_name_30, | |
| check_class TYPE zif_aff_types_v1=>ty_object_name_30, |
| "! Consistency Check Class | ||
| checkclass TYPE zif_aff_types_v1=>ty_object_name_30, | ||
| "! <p class="shorttext">Result Derivation Indicator</p> | ||
| "! Result Process Derived by BAdI |
There was a problem hiding this comment.
| "! Result Process Derived by BAdI | |
| "! Result process derived by BAdI |
| checkclass TYPE zif_aff_types_v1=>ty_object_name_30, | ||
| "! <p class="shorttext">Result Derivation Indicator</p> | ||
| "! Result Process Derived by BAdI | ||
| resultderivationindicator TYPE abap_bool, |
There was a problem hiding this comment.
| resultderivationindicator TYPE abap_bool, | |
| result_derivation_indicator TYPE abap_bool, |
| "! Header | ||
| "! $required | ||
| header TYPE zif_aff_types_v1=>ty_header_60_cloud, | ||
| "! <p class="shorttext">Check ID Definition</p> |
There was a problem hiding this comment.
Should the title here mention attributes as well?
|
|
||
| TYPES: | ||
| "! <p class="shorttext">Consistency Check ID</p> | ||
| "! Check ID (EDCK) v1 |
There was a problem hiding this comment.
| "! Check ID (EDCK) v1 | |
| "! Consistency check ID (EDCK) v1 |
|
|
||
| CONSTANTS: | ||
| "! <p class="shorttext">Check Classification</p> | ||
| "! Check Classification |
There was a problem hiding this comment.
| "! Check Classification | |
| "! Check classification |
|
Furthermore, the example object is missing |
No description provided.