Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy flag and category to interfaces #87

Merged
merged 14 commits into from
May 22, 2021
Merged

Add proxy flag and category to interfaces #87

merged 14 commits into from
May 22, 2021

Conversation

schneidermic0
Copy link
Contributor

Relates to #86.

@larshp
Copy link
Collaborator

larshp commented May 12, 2021

for INTF I see file-formats/intf/zif_aff_intf_v1.intf.abap as being the source, and file-formats/intf/intf.json will sometime be auto-generated and overwritten?

ie. its most important to do the changes in the .abap file

@schneidermic0 schneidermic0 self-assigned this May 12, 2021
@schneidermic0
Copy link
Contributor Author

for INTF I see file-formats/intf/zif_aff_intf_v1.intf.abap as being the source, and file-formats/intf/intf.json will sometime be auto-generated and overwritten?

Actually, I did it this way, but I mixed up files and did not recognise that I didn't add the changes to file-formats/intf/zif_aff_intf_v1.intf.abap

@@ -1,5 +1,19 @@
INTERFACE zif_aff_intf_v1 PUBLIC.

TYPES:
category_base TYPE n LENGTH 2,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false-positive, isn't it? The type is used in the ENUM below as base type

@larshp
Copy link
Collaborator

larshp commented May 12, 2021

different issue: the editor config requires no newline at end of file, editing the file via github web always adds newline at end of file

@larshp larshp mentioned this pull request May 12, 2021
Copy link

@crasovan crasovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

file-formats/intf/format.md Outdated Show resolved Hide resolved
Co-authored-by: Lars Hvam <larshp@hotmail.com>
@larshp
Copy link
Collaborator

larshp commented May 21, 2021

conflicts resolved, lets merge this? and keep #86 open

larshp and others added 3 commits May 21, 2021 13:52
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@larshp
Copy link
Collaborator

larshp commented May 21, 2021

github actions is kind of down, this is the 5th time over the last 7 days...

@schneidermic0 schneidermic0 merged commit 72706c9 into main May 22, 2021
@schneidermic0 schneidermic0 deleted the fix/intf branch May 22, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants