Feature log exception stacktrace #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Write a test for the use case * Check if log is of ERROR level and format the exception info accordingly * Make sure test passes * Try to follow pattern of library
* Add exception method to falcon req object to call logger.exception * Check if stacktrace is correctly returned in sanic and falcon app exceptions
* Abstract stacktrace formatting into subclass of logging.Formatter * Start adding custom formatting behaviour
* Add stacktrace max size library constant * Make StacktraceFormatter an independent formatter * Test StacktraceFormatter * Change record exc_info formatting accordingly
|
|
* Fix tests that broke on python2.7 * Fix linting errors
* Fix pylint tests duplicate code errors * Make property in stacktrace formatter private
* Remove log and exception methods from falcon request * Change stacktrace formatting from a class to a function * Move exception stacktrace test to job log tests so it is in one place only
gvachkov
reviewed
Jul 3, 2018
| def format_stacktrace(stacktrace): | ||
| """ | ||
| Removes newline and tab characters | ||
| Truncates stacktrace to maximum size |
There was a problem hiding this comment.
please add the expected type of stacktrace argument in function docu
| Removes newline and tab characters | ||
| Truncates stacktrace to maximum size | ||
| """ | ||
| stacktrace = re.sub('\n|\t', ' ', stacktrace) |
There was a problem hiding this comment.
I would check that stacktrace is a valid string
| @@ -63,5 +67,9 @@ def format(self): | |||
| 'msg': self.getMessage(), | |||
| }) | |||
|
|
|||
| if record.get('level') == 'ERROR': | |||
There was a problem hiding this comment.
use self.levelno to check log level and compare to logging.ERROR constant instead of comparing strings
tests/test_job_logging.py
Outdated
| try: | ||
| return 1 / 0 | ||
| except ZeroDivisionError: | ||
| logger.exception("zero division error") |
There was a problem hiding this comment.
use single quotes for string literal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21