Added authentication token caching #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwefreidank
reviewed
Jun 14, 2024
| if err == nil { | ||
| spaceClientCache[identifier] = client | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Shouldn't we cover the password rotation for the OrgClient as well?
RalfHammer
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The CF Service Operator currently constructs a new CF Client for every reconcile loop. This means that it has to perform the discovery of the UAA endpoint and the fetching of the token for every reconcile. As these endpoints are unauthenticated, they are subject to stricter rate-limits than the authenticated endpoints, thus leading to a quick exhaustion of the rate limit in the case of many CF resources.
Proposal
This PR proposes a mechanism to cache the CF Client for each combination of API URL and Username (which is guaranteed to identify a unique user), and let the existing oAuth automatic token renewal mechanism of the CF Client renew the token whenever necessary.
Tests
Tests are included to check that the requests are not performed when the CF Client is cached.
Minor additions
I have also changed the secret name of the webhook TLS secret for the local development script, as it did not match that of the helm chart (https://github.com/SAP/cf-service-operator-helm/blob/main/chart/templates/webhook.yaml#L45).