Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support build dependencies between modules in verbose makefile #551

Merged
merged 7 commits into from
Nov 10, 2019
Merged

Support build dependencies between modules in verbose makefile #551

merged 7 commits into from
Nov 10, 2019

Conversation

tal-sapan
Copy link
Contributor

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

allaVolkov
allaVolkov suggested changes Nov 7, 2019
View reviewed changes
cmd/exec_test.go Show resolved Hide resolved
internal/archive/fsops.go Outdated Show resolved Hide resolved
internal/archive/fsops.go Outdated Show resolved Hide resolved
@tal-sapan tal-sapan merged commit 14997d8 into master Nov 10, 2019
@tal-sapan tal-sapan deleted the module_dep_in_verbose branch November 10, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allaVolkov allaVolkov allaVolkov approved these changes

@ShimiT ShimiT Awaiting requested review from ShimiT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tal-sapan @allaVolkov