Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for phone link when duplicated prefix 'tel' #24

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Bug fix for phone link when duplicated prefix 'tel' #24

merged 2 commits into from
Aug 3, 2021

Conversation

ShadowTourist
Copy link
Contributor

@ShadowTourist ShadowTourist commented Aug 3, 2021 •
edited
Loading

Bug fix for phone link when duplicated prefix 'tel'

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@justinguo
Copy link

@ShadowTourist This PR looks good to me. Can you check if the CLA has been signed? You might click on the above link or click the recheck link if you already signed. Ideally, after CLA is signed, then all PR jobs in CI process will run for each PR.

@ShadowTourist
Copy link
Contributor Author

@ShadowTourist This PR looks good to me. Can you check if the CLA has been signed? You might click on the above link or click the recheck link if you already signed. Ideally, after CLA is signed, then all PR jobs in CI process will run for each PR.

CLA signed now.

@MarcoEidinger
Copy link
Member

Ignore failing beta build. In future please use https://github.com/streamich/git-cz to ensure proper commit message as CHANGELOG will be generated based on commit message information. No action needed here as I will squash and merge with new commit message.

@MarcoEidinger MarcoEidinger self-requested a review August 3, 2021 10:49
@justinguo
Copy link

@ShadowTourist Can you check streamich/git-cz out to see if you can formate the commit message correctly? If you like you can create another commit with formatted message. As a reference, a good name for this commit can be:
fix: 🐛 fix phone link in button for duplicated tel prefix. As long as the commit message is clear and specific then it would be fine.

MarcoEidinger
MarcoEidinger approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@MarcoEidinger MarcoEidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

P.S.: I changed my mind last minute to do additional formatting (i.e. removing whitespace) to make the example (DemoBot: "Demo 6" utterance) work

@MarcoEidinger
Copy link
Member

@justinguo I will squash and merge with new commit message.

@ShadowTourist for the future use tools(like git-cz) to ensure conventional commits

@MarcoEidinger MarcoEidinger merged commit fe7ad4a into SAP:dev Aug 3, 2021
MarcoEidinger added a commit that referenced this pull request Aug 3, 2021
@ShadowTourist @MarcoEidinger
fix: 🐛 handle phonenumber button type with "tel:" prefix (#24)
791f960 
CAI developer should maintain values for phonenumber button
without "tel:" prefix. This fix will ensure that links already
containing  "tel:" prefix will also work.

https://sapjira.wdf.sap.corp/browse/HCPSDKFIORIUIKIT-2001

Co-authored-by: MarcoEidinger <eidingermarco@gmail.com>
@ShadowTourist ShadowTourist deleted the bug_fix_for_phone_link_prefix branch August 12, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoEidinger MarcoEidinger MarcoEidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ShadowTourist @CLAassistant @justinguo @MarcoEidinger