-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for phone link when duplicated prefix 'tel' #24
Bug fix for phone link when duplicated prefix 'tel' #24
Conversation
Bug fix for phone link when duplicated prefix 'tel' https://sapjira.wdf.sap.corp/browse/HCPSDKFIORIUIKIT-2001?workflowName=WF+Scrum&stepId=1
@ShadowTourist This PR looks good to me. Can you check if the CLA has been signed? You might click on the above link or click the recheck link if you already signed. Ideally, after CLA is signed, then all PR jobs in CI process will run for each PR. |
CLA signed now. |
Ignore failing beta build. In future please use https://github.com/streamich/git-cz to ensure proper commit message as CHANGELOG will be generated based on commit message information. No action needed here as I will squash and merge with new commit message. |
@ShadowTourist Can you check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
P.S.: I changed my mind last minute to do additional formatting (i.e. removing whitespace) to make the example (DemoBot: "Demo 6" utterance) work
@justinguo I will squash and merge with new commit message. @ShadowTourist for the future use tools(like git-cz) to ensure conventional commits |
CAI developer should maintain values for phonenumber button without "tel:" prefix. This fix will ensure that links already containing "tel:" prefix will also work. https://sapjira.wdf.sap.corp/browse/HCPSDKFIORIUIKIT-2001 Co-authored-by: MarcoEidinger <eidingermarco@gmail.com>
Bug fix for phone link when duplicated prefix 'tel'