New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: central demo application #82
Conversation
I'd like to unify the various apps into a single demo app. Motivation
Any reasons not to do so? @shengxu7 please check the app related to charts I have not yet beautified the app. It is basically a direct blend of the three previous apps. The three previous apps still have to be deleted. I just deleted the references in the workspace. Please leave your review and I'll amend the commit with related change before merging. |
@shengxu7 and @ShawnMa16 : please provide feedback until tomorrow (Tuesday) lunch time. Thanks in advance :) |
@MarcoEidinger I think that's fine. The trick will be keeping the feature discovery manageable--see the ReusableUITestApplication as evidence. Maybe we can use the new SwiftUI hierarchical lists? |
unify the different dev and demo apps into a single app to illustrate examples of the provided UI components
307c691
to
6f79111
Compare
I amended my PR to fix the issue that icons are not loaded for cards. Thanks @ShawnMa16 for the feedback. @shengxu7 any feedback or concerns? Before I merge (around 1pm unless I hear a veto) I'll do another amend to delete the three previous apps. @sstadelman I'll create an issue and add it to the backlog to use new SwiftUI hierarchical list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration cards part looks good
unify the different dev and demo apps into a single app to illustrate examples of the provided UI
components