Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: central demo application #82

Merged
merged 2 commits into from Jul 21, 2020

Conversation

MarcoEidinger
Copy link
Member

unify the different dev and demo apps into a single app to illustrate examples of the provided UI
components

@MarcoEidinger MarcoEidinger requested a review from a team as a code owner July 17, 2020 01:08
@MarcoEidinger MarcoEidinger requested review from sstadelman, ShawnMa16, shengxu7 and billzhou0223 and removed request for a team July 17, 2020 01:08
@MarcoEidinger
Copy link
Member Author

I'd like to unify the various apps into a single demo app.

Motivation

  • better marketing
  • can be used as a foundation to run snapshot tests

Any reasons not to do so?

@shengxu7 please check the app related to charts
@ShawnMa16 please check the app related for integration cards

I have not yet beautified the app. It is basically a direct blend of the three previous apps.

The three previous apps still have to be deleted. I just deleted the references in the workspace. Please leave your review and I'll amend the commit with related change before merging.

@MarcoEidinger
Copy link
Member Author

@shengxu7 and @ShawnMa16 : please provide feedback until tomorrow (Tuesday) lunch time. Thanks in advance :)

@sstadelman
Copy link
Contributor

@MarcoEidinger I think that's fine. The trick will be keeping the feature discovery manageable--see the ReusableUITestApplication as evidence. Maybe we can use the new SwiftUI hierarchical lists?

unify the different dev and demo apps into a single app to illustrate examples of the provided UI
components
@MarcoEidinger
Copy link
Member Author

I amended my PR to fix the issue that icons are not loaded for cards. Thanks @ShawnMa16 for the feedback.

@shengxu7 any feedback or concerns?

Before I merge (around 1pm unless I hear a veto) I'll do another amend to delete the three previous apps.

@sstadelman I'll create an issue and add it to the backlog to use new SwiftUI hierarchical list.

Copy link
Contributor

@ShawnMa16 ShawnMa16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration cards part looks good

@MarcoEidinger
Copy link
Member Author

Thanks to everyone for the feedback and review. Here is the final result

ExamplesApp

@MarcoEidinger MarcoEidinger merged commit 0117115 into SAP:main Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants