fix: allow noauthentication destinations with proxytype “OnPremise” #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekshas8
approved these changes
Dec 13, 2023
.changeset/great-ads-live.md
Outdated
| '@sap-cloud-sdk/connectivity': minor | ||
| --- | ||
|
|
||
| [Fixed Issue] Allow the use of authentication type "NoAuthentication" with proxy type "OnPremise" without requiring the "SAP-Connectivity-Authentication" header. |
There was a problem hiding this comment.
[nth] Use backticks instead of double quotes
marikaner
commented
Dec 13, 2023
Co-authored-by: Deeksha Sinha <88374536+deekshas8@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/SAP/cloud-sdk-backlog/issues/1160
Fix NoAuthentication for proxytype "OnPremise". This behavior existed only due to a historic bug, which was worked around like this.
We contacted the colleagues from BTP connectivity and learned that this headers is in fact not needed (and incorrect) when using NoAuthentication.