fix: Fix quote issue in path pattern #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-flannery
reviewed
Apr 15, 2024
| @@ -15,7 +15,7 @@ import { serializeSchema } from './schema'; | |||
| export function serializeOperation(operation: OpenApiOperation): string { | |||
| const requestBuilderParams = [ | |||
| `'${operation.method}'`, | |||
| `'${operation.pathPattern}'` | |||
| `"${operation.pathPattern}"` | |||
There was a problem hiding this comment.
Let me check if I understood this correctly:
- there exist APIs that expect params to be passed like this:
example.com/api/entities('5')/something - because we used single quotes for the string, the generated code looked like this
'test('{id}')', which is syntactically incorrect?
There was a problem hiding this comment.
The ideas some API providers have... 😒
mr-flannery
approved these changes
Apr 15, 2024
Yes, it generates successfully now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SAP/cloud-sdk-backlog#4572
Fixes error in generating open api client. Api having path format
/path('{param}')/{id}result in syntax error when client is generated. Generation fails with:ErrorWithCause: Could not write file...