Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove httpclient caching from DefaultHttpClientFactory #1416

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

liga-oz
Copy link
Contributor

@liga-oz liga-oz commented Jan 3, 2024

HttpClient caching in DefaultHttpClientFactory does not add any value to the way how it is used across the other library modules, where the created httpClient is stored as a field variable in the corresponding classes and reused from there.

Moreover, as the service configuration is loaded once per app start, extending a cache with a cache key that include a clientid, a certificate thumbprint and implementing also a cache eviction logic would not have any impact on key rotation without app restart and therefore caching the http connections would not bring anything.

liga-oz and others added 2 commits January 3, 2024 09:10
Signed-off-by: liga-oz <liga.ozolina@sap.com>
Signed-off-by: liga-oz <liga.ozolina@sap.com>
@liga-oz liga-oz merged commit 92d1888 into main Jan 3, 2024
5 checks passed
@liga-oz liga-oz deleted the 3_remove_httpclient_caching branch January 3, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant