Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XsuaaDefaultEndpoints: provide another constructor to compensate the deprecated one #708

Merged
merged 6 commits into from
Nov 10, 2021
Merged

XsuaaDefaultEndpoints: provide another constructor to compensate the deprecated one #708

merged 6 commits into from
Nov 10, 2021

Conversation

nenaraab
Copy link
Contributor

@nenaraab nenaraab commented Nov 8, 2021 •
edited
Loading

fixes #707

Hi @liga-oz
Alternatively we could provide a new constructor

XsuaaDefaultEndpoints(String baseUri, @Nullable String certUri)

Furthermore, we could set the default certUri by adding the that https://subdomain.authentication.cert.domain

@nenaraab nenaraab requested a review from liga-oz November 8, 2021 17:50
liga-oz
liga-oz requested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@liga-oz liga-oz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's keep the deprecated constructors deprecated and introduce new constructor with arguments uri and certuri(@nullable)

@nenaraab nenaraab requested a review from liga-oz November 9, 2021 17:33
@nenaraab nenaraab changed the title XsuaaDefaultEndpoints: undo deprecation from constructor XsuaaDefaultEndpoints: provide another constructor to compensate the deprecated one Nov 10, 2021
liga-oz
liga-oz requested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@liga-oz liga-oz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so much better, well done 👍🏻

token-client/src/main/java/com/sap/cloud/security/xsuaa/client/XsuaaDefaultEndpoints.java Outdated Show resolved Hide resolved
token-client/src/main/java/com/sap/cloud/security/xsuaa/client/XsuaaDefaultEndpoints.java Outdated Show resolved Hide resolved
token-client/src/main/java/com/sap/cloud/security/xsuaa/client/XsuaaDefaultEndpoints.java Outdated Show resolved Hide resolved
token-client/src/test/java/com/sap/cloud/security/xsuaa/client/XsuaaDefaultEndpointsTest.java Show resolved Hide resolved
liga-oz
liga-oz approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@liga-oz liga-oz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@liga-oz liga-oz merged commit b6003b7 into main Nov 10, 2021
@liga-oz liga-oz deleted the gh-707 branch November 10, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liga-oz liga-oz liga-oz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XsuaaTokenFlows: Deprecated constructors for client credential based authentication
2 participants
@nenaraab @liga-oz