-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GetBaseReport Implementation and Add Request Handlers and CLI Parsing Server-Side #1053
Conversation
Sekiya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please:
- run the poetry task to format the code: github action failure
- sign the CLA
- please use https://www.conventionalcommits.org/en/v1.0.0/ for commit messages: you usually can't bypass the post-commit hook unless you have not properly setup the simulator code base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merge it in its current state, but:
- The implementation does not address all comments
- The implementation does not work ...
- The CLA is not signed
I will make a PR to address the remaining to review as a learning exercice. Too much time spent on that step. Please move to the next step: simulator side.
This pull request rectifies the server-side implementation of the GetBaseReport. It resolves the mistaken role of the CSMS as the receiver instead of the request emitter.
Key updates include:
The primary purpose of these changes is to facilitate the sending of an OCPP command to any connected CS, hence the inclusion of CLI parsing server-side. This allows for the periodic initiation of a given OCPP command, useful for testing its handling simulator side.