Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetBaseReport Implementation and Add Request Handlers and CLI Parsing Server-Side #1053

Merged
merged 27 commits into from
Jun 27, 2024

Conversation

syuusei3
Copy link

This pull request rectifies the server-side implementation of the GetBaseReport. It resolves the mistaken role of the CSMS as the receiver instead of the request emitter.

Key updates include:

  1. Addition of request handlers server-side, beginning with the GetBaseReport.
  2. Incorporation of an API capable of manually triggering these handlers on any connected Charging Station (CS). Initialization can be achieved via CLI options such as --request <OCPP2_Command_Name> --delay , or --period .

The primary purpose of these changes is to facilitate the sending of an OCPP command to any connected CS, hence the inclusion of CLI parsing server-side. This allows for the periodic initiation of a given OCPP command, useful for testing its handling simulator side.

Copy link

cla-assistant bot commented Jun 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ jerome-benoit
❌ Sekiya
❌ autofix-ci[bot]


Sekiya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@jerome-benoit jerome-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • run the poetry task to format the code: github action failure
  • sign the CLA
  • please use https://www.conventionalcommits.org/en/v1.0.0/ for commit messages: you usually can't bypass the post-commit hook unless you have not properly setup the simulator code base

tests/ocpp-server/.gitignore Outdated Show resolved Hide resolved
tests/ocpp-server/README.md Outdated Show resolved Hide resolved
tests/ocpp-server/README.md Outdated Show resolved Hide resolved
tests/ocpp-server/README.md Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/README.md Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
tests/ocpp-server/server.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jerome-benoit jerome-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge it in its current state, but:

  • The implementation does not address all comments
  • The implementation does not work ...
  • The CLA is not signed

I will make a PR to address the remaining to review as a learning exercice. Too much time spent on that step. Please move to the next step: simulator side.

@jerome-benoit jerome-benoit merged commit 3a31492 into SAP:main Jun 27, 2024
22 of 23 checks passed
@syuusei3 syuusei3 deleted the issue39-ocpp2 branch July 1, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants