Skip to content

Commit

Permalink
fix(core): Add menu option to button (#1565)
Browse files Browse the repository at this point in the history
  • Loading branch information
JKMarkowski committed Nov 8, 2019
1 parent 5cb01b5 commit 7523438
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<fd-docs-section-title [id]="'Button-options'" [componentName]="'button'"> Button Options </fd-docs-section-title>
<description>
There are three emphasis styles used to indicate the importance of the button on the page. Do not provide a value
for the default option. Use <code class="code-snippet">[options]="'emphasized'"</code> or
<code class="code-snippet">[options]="'light'"</code> to set the option.
for the default option. Use <code class="code-snippet">[options]="'emphasized'"</code>,
<code class="code-snippet">[options]="'menu'"</code> or
<code class="code-snippet">[options]="'light'"</code> to set the option. Options also can be combined in the array.
For example<code class="code-snippet">[options]="['emphasized', 'menu']"</code>
</description>
<component-example [name]="'ex0'">
<fd-button-options-example></fd-button-options-example>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class ButtonDocsComponent implements OnInit {
},
options: {
type: 'string',
enum: ['', 'emphasized', 'light']
enum: ['', 'emphasized', 'light', 'menu']
},
compact: {
type: 'boolean'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<button fd-button>Regular Button</button>
<button fd-button [options]="'emphasized'">Emphasized Button</button>
<button fd-button [options]="'light'">Light Button</button>
<button fd-button [options]="'menu'">Menu Button</button>
<button fd-button [options]="['menu', 'emphasized']">Emphasized Menu Button</button>
<button fd-button [options]="['menu', 'light']">Light Menu Button</button>
2 changes: 1 addition & 1 deletion libs/core/src/lib/button/button.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { AbstractFdNgxClass } from '../utils/abstract-fd-ngx-class';


export type ButtonType = 'standard' | 'positive' | 'medium' | 'negative' | 'half';
export type ButtonOptions = 'light' | 'emphasized';
export type ButtonOptions = 'light' | 'emphasized' | 'menu';

/**
* Button directive, used to enhance standard HTML buttons.
Expand Down

0 comments on commit 7523438

Please sign in to comment.