fix: (Core) remove card-footer component (#5158)

* fix:remove card-footer component * removed card footer from api-file * fix travis
SAP · May 3, 2021 · 7a1c221 · 7a1c221
1 parent 1c2466e
commit 7a1c221
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 81 deletions.
diff --git a/apps/docs/src/app/core/api-files.ts b/apps/docs/src/app/core/api-files.ts
@@ -38,7 +38,6 @@ export const API_FILES = {
         'CardSubtitleDirective',
         'CardSecondSubtitleDirective',
         'CardContentComponent',
-        'CardFooterComponent',
         'CardLoaderComponent',
         'CardKpiHeaderComponent',
         'CardKpiValueDirective',

diff --git a/apps/docs/src/app/core/component-docs/card/card-docs.module.ts b/apps/docs/src/app/core/component-docs/card/card-docs.module.ts
@@ -3,6 +3,7 @@ import { RouterModule, Routes } from '@angular/router';
 
 import {
     CardModule,
+    BarModule,
     ButtonModule,
     BusyIndicatorModule,
     ObjectStatusModule,
@@ -51,6 +52,7 @@ const routes: Routes = [
         RouterModule.forChild(routes),
         SharedDocumentationPageModule,
         CardModule,
+        BarModule,
         ButtonModule,
         BusyIndicatorModule,
         ObjectStatusModule,

diff --git a/apps/docs/src/app/core/component-docs/card/examples/card-footer-example.component.html b/apps/docs/src/app/core/component-docs/card/examples/card-footer-example.component.html
@@ -25,11 +25,13 @@ <h2 fd-card-title>Card Title</h2>
                 </span>
             </li>
         </ul>
+        <div fd-bar barDesign="footer" [cozy]="false">
+            <div fd-bar-right>
+                <fd-toolbar size="compact" fdType="transparent" [clearBorder]="true">
+                    <button fd-toolbar-item fd-button fdType="positive" [compact]="true">Approve</button>
+                    <button fd-toolbar-item fd-button fdType="negative" [compact]="true">Reject</button>
+                </fd-toolbar>
+            </div>
+        </div>
     </fd-card-content>
-    <fd-card-footer>
-        <fd-toolbar size="compact" fdType="transparent" [clearBorder]="true">
-            <button fd-toolbar-item fd-button fdType="positive" [compact]="true">Approve</button>
-            <button fd-toolbar-item fd-button fdType="negative" [compact]="true">Reject</button>
-        </fd-toolbar>
-    </fd-card-footer>
 </fd-card>
diff --git a/.../core/component-docs/card/examples/quick-view-card/card-quick-view-example.component.html b/.../core/component-docs/card/examples/quick-view-card/card-quick-view-example.component.html
@@ -35,11 +35,13 @@ <h2 fd-card-title>Contact Card</h2>
                     </fd-quick-view-group-item>
                 </fd-quick-view-group>
             </fd-quick-view>
+            <div fd-bar barDesign="footer" [cozy]="false">
+                <div fd-bar-right>
+                    <fd-toolbar size="compact" fdType="transparent" [clearBorder]="true">
+                        <button fd-toolbar-item fd-button [compact]="true">Assign to Project</button>
+                    </fd-toolbar>
+                </div>
+            </div>
         </fd-card-content>
-        <fd-card-footer>
-            <fd-toolbar size="compact" fdType="transparent" [clearBorder]="true">
-                <button fd-toolbar-item fd-button [compact]="true">Assign to Project</button>
-            </fd-toolbar>
-        </fd-card-footer>
     </fd-card>
 </div>
diff --git a/e2e/wdio/core/pages/card.po.ts b/e2e/wdio/core/pages/card.po.ts
@@ -24,7 +24,7 @@ export class CardPo extends CoreBaseComponentPo {
     // footer examples
     ftCardHeader = 'fd-card-footer-example fd-card-header';
     ftCardListItems = 'fd-card-footer-example li';
-    ftFooter = 'fd-card-footer-example fd-card-footer';
+    ftFooter = 'fd-card-footer-example .fd-bar .fd-bar__right';
     ftButtons = 'fd-card-footer-example fd-toolbar button';
     // analytical card examples
     kpiCardHeader = 'fd-card-kpi-example fd-card-header';

diff --git a/libs/core/src/lib/card/card-footer.component.spec.ts b/libs/core/src/lib/card/card-footer.component.spec.ts
diff --git a/libs/core/src/lib/card/card-footer.component.ts b/libs/core/src/lib/card/card-footer.component.ts
diff --git a/libs/core/src/lib/card/card.module.ts b/libs/core/src/lib/card/card.module.ts
@@ -12,7 +12,6 @@ import { CardSubtitleDirective } from './card-subtitle.directive';
 import { CardSecondSubtitleDirective } from './card-second-subtitle.directive';
 import { CardCounterDirective } from './card-counter.directive';
 import { CardContentComponent } from './card-content.component';
-import { CardFooterComponent } from './card-footer.component';
 import { CardLoaderComponent } from './card-loader.component';
 
 import { CardKpiHeaderComponent } from './kpi/card-kpi-header.component';
@@ -27,7 +26,6 @@ const components = [
     CardComponent,
     CardHeaderComponent,
     CardContentComponent,
-    CardFooterComponent,
     CardTitleDirective,
     CardSubtitleDirective,
     CardSecondSubtitleDirective,

diff --git a/libs/core/src/lib/card/public_api.ts b/libs/core/src/lib/card/public_api.ts
@@ -6,7 +6,6 @@ export { CardTitleDirective } from './card-title.directive';
 export { CardSubtitleDirective } from './card-subtitle.directive';
 export { CardSecondSubtitleDirective } from './card-second-subtitle.directive';
 export { CardContentComponent } from './card-content.component';
-export { CardFooterComponent } from './card-footer.component';
 export { CardLoaderComponent } from './card-loader.component';
 
 export { CardKpiHeaderComponent } from './kpi/card-kpi-header.component';