Skip to content

Commit

Permalink
fix: (Core) combobox minor tweaks for defect hunting (#5013)
Browse files Browse the repository at this point in the history
* remove combobox max width

* hide dropdown button for mobile combobox

* put back combobox max width (but now 640px)
  • Loading branch information
mikerodonnell89 committed Mar 31, 2021
1 parent 5fdafda commit b4cbe64
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion libs/core/src/lib/combobox/combobox.component.html
Expand Up @@ -9,8 +9,8 @@
[fillControlMode]="fillControlMode"
[focusTrapped]="true"
[triggers]="triggers"
[maxWidth]="600"
[disabled]="disabled || readOnly"
[maxWidth]="640"
[closeOnOutsideClick]="closeOnOutsideClick">
<fd-popover-control>
<ng-container *ngTemplateOutlet="controlTemplate"></ng-container>
Expand Down
3 changes: 3 additions & 0 deletions libs/core/src/lib/combobox/combobox.component.ts
Expand Up @@ -357,6 +357,9 @@ export class ComboboxComponent implements ComboboxInterface, ControlValueAccesso

/** @hidden */
ngOnInit(): void {
if (this.mobile) {
this.showDropdownButton = false;
}
this._refreshDisplayedValues();
if (this.compact === undefined && this._contentDensityService) {
this._subscriptions.add(this._contentDensityService._contentDensityListener.subscribe(density => {
Expand Down

0 comments on commit b4cbe64

Please sign in to comment.