docs: fix combobox and table docs (#3191)

* fix combobox and table docs * more fixes * allow empty
SAP · Sep 3, 2020 · d0d49b1 · d0d49b1
1 parent 69989b0
commit d0d49b1
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 6 deletions.
diff --git a/...cs/src/app/core/component-docs/combobox/examples/combobox-disabled-example.component.html b/...cs/src/app/core/component-docs/combobox/examples/combobox-disabled-example.component.html
@@ -2,7 +2,7 @@
     <fieldset fd-fieldset class="flex-form">
         <div fd-form-item>
             <label fd-form-label for="form-combo-2">Select Fruit:</label>
-            <fd-combobox formControlName="disabledComboControl" fd-form-control id="form-combo-2"></fd-combobox>
+            <fd-combobox formControlName="disabledComboControl" id="form-combo-2"></fd-combobox>
             Disabled: {{ customForm.controls.disabledComboControl.disabled }}<br />
             Selected Value: {{ customForm.controls.disabledComboControl.value }}
         </div>

diff --git a/...input-group/examples/input-group-states-example/input-group-states-example.component.html b/...input-group/examples/input-group-states-example/input-group-states-example.component.html
@@ -20,7 +20,6 @@
     <label fd-form-label>Success</label>
     <fd-form-input-message-group>
         <fd-input-group
-            fd-form-control
             [addOnText]="'Button'"
             [compact]="true"
             [button]="true"
@@ -39,7 +38,6 @@
     <label fd-form-label>Warning</label>
     <fd-form-input-message-group>
         <fd-input-group
-            fd-form-control
             [addOnText]="'Button'"
             [button]="true"
             [state]="'warning'"
@@ -57,7 +55,6 @@
     <label fd-form-label>Error</label>
     <fd-form-input-message-group>
         <fd-input-group
-            fd-form-control
             [addOnText]="'Button'"
             [button]="true"
             [state]="'error'"

diff --git a/apps/docs/src/app/core/component-docs/table/table-docs.module.ts b/apps/docs/src/app/core/component-docs/table/table-docs.module.ts
@@ -33,6 +33,7 @@ import { TableToolbarExampleComponent } from './examples/table-toolbar-example.c
 import { TableCustomDialogComponent } from './examples/table-custom-columns-example/table-custom-dialog.component';
 import { CdkTableModule } from '@angular/cdk/table';
 import { DragDropModule } from '@angular/cdk/drag-drop';
+import { SharedDocumentationModule } from '../../../documentation/shared-documentation.module';
 
 const routes: Routes = [
     {
@@ -61,6 +62,7 @@ const routes: Routes = [
         ObjectStatusModule,
         SharedDocumentationPageModule,
         RouterModule.forChild(routes),
+        SharedDocumentationModule
     ],
     exports: [RouterModule],
     declarations: [

diff --git a/apps/docs/src/app/core/documentation/core-documentation.component.ts b/apps/docs/src/app/core/documentation/core-documentation.component.ts
@@ -52,7 +52,6 @@ export class CoreDocumentationComponent extends DocumentationBaseComponent {
             { url: 'core/popover', name: 'Popover' },
             { url: 'core/product-switch', name: 'Product Switch' },
             { url: 'core/radio', name: 'Radio Button' },
-            { url: 'core/select-native', name: 'Select Native' },
             { url: 'core/select', name: 'Select' },
             { url: 'core/shellbar', name: 'Shellbar' },
             { url: 'core/sideNavigation', name: 'Side Navigation' },

diff --git a/libs/core/src/lib/combobox/combobox.component.html b/libs/core/src/lib/combobox/combobox.component.html
@@ -39,7 +39,7 @@
     <fd-input-group
         [compact]="compact"
         [button]="showDropdownButton"
-        [glyph]="showDropdownButton ? glyph : ''"
+        [glyph]="showDropdownButton ? glyph : ' '"
         [state]="state"
         [buttonFocusable]="buttonFocusable"
         [disabled]="disabled || readOnly"