fix: add type button to input group and select (#2154)

* add type to select button Add a type to the select button so it no longer submits forms * add type button to buttons in an input group
SAP · Mar 12, 2020 · d5c48db · d5c48db
1 parent 42f0211
commit d5c48db
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/libs/core/src/lib/input-group/input-group.component.html b/libs/core/src/lib/input-group/input-group.component.html
@@ -25,7 +25,8 @@
                     [options]="buttonOptions"
                     [glyph]="glyph"
                     [class]="inShellbar ? 'fd-shellbar__button' : ''"
-                    (click)="buttonClicked($event)">
+                    (click)="buttonClicked($event)"
+                    type="button">
                 <ng-container *ngIf="!glyph">{{addOnText}}</ng-container>
             </button>
         </span>

diff --git a/libs/core/src/lib/select/select.component.html b/libs/core/src/lib/select/select.component.html
@@ -22,6 +22,7 @@
                     'fd-button--noborder': selectType === 'noborder',
                     'fd-button--splitborder': selectType === 'splitborder'
                 }"
+                type="button"
             >
                 <fd-icon *ngIf="glyph" size="m" [glyph]="glyph" class="fd-template-icon icon-position"> </fd-icon>
                 <span class="fd-select-text-custom" [dir]="dir$ | async">{{ triggerValue }}</span>