Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Button Playground Types not reflected #311

Closed
thomasgauvin opened this issue Nov 20, 2018 · 0 comments
Closed

Bug Button Playground Types not reflected #311

thomasgauvin opened this issue Nov 20, 2018 · 0 comments
Assignees
@thomasgauvin
Labels
bug Something isn't working documentation There is an issue with documentation good first issue Good for newcomers
Projects
board

Comments

@thomasgauvin
Copy link
Contributor

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

Types not reflected and also the new types are not listed in the playground.

Which versions of Angular and Fundamental NGX are affected? (If this is a feature request, use current version.)

Angular 6, fundamental-ngx beta-20

If this is a bug, please provide steps for reproducing it.

On the button, the playground doesn't show the correct types and the types do not take effect in the playground.

Please provide relevant source code if applicable.

Is there anything else we should know?
@thomasgauvin thomasgauvin self-assigned this Nov 20, 2018
@thomasgauvin thomasgauvin added bug Something isn't working documentation There is an issue with documentation good first issue Good for newcomers labels Nov 20, 2018
@thomasgauvin thomasgauvin mentioned this issue Nov 21, 2018
Closed
thomasgauvin added a commit that referenced this issue Nov 22, 2018
@thomasgauvin
Merge branch 'develop' into feature/#311
b529064
@thomasgauvin thomasgauvin mentioned this issue Nov 22, 2018
Merged
mikerodonnell89 added a commit that referenced this issue Nov 26, 2018
@mikerodonnell89
Merge pull request #319 from SAP/feature/#311-refactor-button-component
ada6597 
#311: Refactored to deprecate semantics, fix playground not showing up and …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasgauvin thomasgauvin

Labels
bug Something isn't working documentation There is an issue with documentation good first issue Good for newcomers
Projects
No open projects
board
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikerodonnell89 @thomasgauvin