Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table sorting freature #432

Closed
droshev opened this issue Jan 21, 2019 · 3 comments
Closed

Table sorting freature #432

droshev opened this issue Jan 21, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@droshev
Copy link
Contributor

droshev commented Jan 21, 2019

Is this a bug, enhancement, or feature request?

enhancement

Briefly describe your proposal.

The table columns are not sortable at the moment

Which versions of Angular and Fundamental NGX are affected? (If this is a feature request, use current version.)

angular 7.1, fundamental-ngx 0.0.29 beta

@droshev droshev added enhancement New feature or request help wanted Extra attention is needed MVP1 labels Jan 21, 2019
@MattL75
Copy link
Contributor

MattL75 commented Jan 21, 2019

Currently we don't take in the data from the user. Instead, they define the headers and rows themselves. To make a sorting component, we'd need access to the data and so require users to pass it as input. Doing so limits customization with our current setup, but we could expand it. Thoughts on this @mikerodonnell89 ?

I know @fkolar wanted us to use the Material CDK.

@mikerodonnell89 mikerodonnell89 self-assigned this Jan 23, 2019
@mikerodonnell89
Copy link
Member

mikerodonnell89 commented Jan 23, 2019

@droshev @MattL75 Here's a simple solution that has the dev define their own sorting algorithms, so this sticks with the pattern where they define headers and rows themselves. I think it's important to let the dev define their own sorting algorithms because we can only assume so much about the data coming in and how they want to handle it. But some users may want a more strict API (#423). This could be a good intermediary solution while we develop said API

https://github.com/SAP/fundamental-ngx/tree/enhancement/%23432-table-sort

mikerodonnell89 added a commit that referenced this issue Jan 24, 2019
* table sort directive example

* docs for column sorting, rename fdTableSortable to fdColumnSortable
@MattL75
Copy link
Contributor

MattL75 commented Jan 26, 2019

Closing this as it's sufficient for MVP1. We can create a new issue to track progress in the new API once it's underway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants