-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table sorting freature #432
Comments
Currently we don't take in the data from the user. Instead, they define the headers and rows themselves. To make a sorting component, we'd need access to the data and so require users to pass it as input. Doing so limits customization with our current setup, but we could expand it. Thoughts on this @mikerodonnell89 ? I know @fkolar wanted us to use the Material CDK. |
@droshev @MattL75 Here's a simple solution that has the dev define their own sorting algorithms, so this sticks with the pattern where they define headers and rows themselves. I think it's important to let the dev define their own sorting algorithms because we can only assume so much about the data coming in and how they want to handle it. But some users may want a more strict API (#423). This could be a good intermediary solution while we develop said API https://github.com/SAP/fundamental-ngx/tree/enhancement/%23432-table-sort |
* table sort directive example * docs for column sorting, rename fdTableSortable to fdColumnSortable
Closing this as it's sufficient for MVP1. We can create a new issue to track progress in the new API once it's underway |
Is this a bug, enhancement, or feature request?
enhancement
Briefly describe your proposal.
The table columns are not sortable at the moment
Which versions of Angular and Fundamental NGX are affected? (If this is a feature request, use current version.)
angular 7.1, fundamental-ngx 0.0.29 beta
The text was updated successfully, but these errors were encountered: