Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Public API Declarations #455

Closed
damien-murphy opened this issue Jan 25, 2019 · 1 comment
Closed

Missing Public API Declarations #455

damien-murphy opened this issue Jan 25, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Projects

Comments

@damien-murphy
Copy link

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

Add missing Modules to the public API

https://github.com/SAP/fundamental-ngx/blob/develop/library/src/public_api.ts

export * from './lib/calendar/calendar.module';
export * from './lib/date-picker/date-picker.module';
export * from './lib/popover/popover.module';
export * from './lib/toggle/toggle.module';
export * from './lib/utils/utils.module';

Which versions of Angular and Fundamental NGX are affected? (If this is a feature request, use current version.)

Latest

If this is a bug, please provide steps for reproducing it.

Attempt to import the missing modules from the public API

Please provide relevant source code if applicable.

See above

Is there anything else we should know?

@droshev droshev added bug Something isn't working MVP1 labels Jan 25, 2019
@MattL75 MattL75 self-assigned this Jan 25, 2019
MattL75 added a commit that referenced this issue Jan 25, 2019
@damien-murphy
Copy link
Author

damien-murphy commented Jan 25, 2019

When I make these changes locally to add the missing public api declariations it give the following error for all of the newly added components

ERROR in : Unexpected value 'CalendarModule in /xxx/node_modules/fundamental-ngx/fundamental-ngx.d.ts' 
imported by the module 'FundamentalNGXModule in /xxx/src/app/utilities/fundamental-ngx.module.ts'. 
Please add a @NgModule annotation.

MattL75 added a commit that referenced this issue Jan 26, 2019
mikerodonnell89 pushed a commit that referenced this issue Jan 28, 2019
* #455 added modules to public_api

* #455 added infinite scroll module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
board
  
Awaiting triage
Development

No branches or pull requests

4 participants