Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover body positioning wrong when scrolling #594

Closed
maxmarkus opened this issue Mar 1, 2019 · 2 comments · Fixed by #633
Closed

Popover body positioning wrong when scrolling #594

maxmarkus opened this issue Mar 1, 2019 · 2 comments · Fixed by #633
Assignees
Labels
bug Something isn't working

Comments

@maxmarkus
Copy link

Hello,

We're having an issue with popover positioning inside a modal, if the modal has scrollable content.
The fd-modal .fd-modal .fd-popover__body is set to position: fixed which leads to weird behavior when scrolling inside the modal, as you can see at the screenshot.

screen markus e 2019-03-01 at 14 20 41

We've solved it by setting the position to absolute with ::ng-deep fd-modal .fd-modal .fd-popover__body { position: absolute; }.
Since ng-deep will be deprecated somewhen in the future, we cannot stick to this solution.

Best, Markus

@MattL75
Copy link
Contributor

MattL75 commented Mar 1, 2019

This will be fixed by #410 through Popper.js, but the ticket is waiting on SAP/fundamental#1286

@droshev
Copy link
Contributor

droshev commented Mar 1, 2019

@maxmarkus Thanks for raising the issue, we will update you soon.

@MattL75 MattL75 added the bug Something isn't working label Mar 11, 2019
@MattL75 MattL75 self-assigned this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants