Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: popover improvements #633

Merged
merged 20 commits into from
Mar 20, 2019
Merged

feat: popover improvements #633

merged 20 commits into from
Mar 20, 2019

Conversation

MattL75
Copy link
Contributor

@MattL75 MattL75 commented Mar 18, 2019 •
edited by mikerodonnell89
Loading

Please provide a link to the associated issue.

fixes #621
fixes #608
fixes #594
fixes #410

Please provide a brief summary of this pull request.

  • Added Popper.js
  • Added a popover directive which integrates Popper.js
  • Integrated the popover directive within the popover component
  • Did some css (different from fd-react's, but we can unify that later) for the popover
  • Documentation on common use-cases

@MattL75 MattL75 changed the title feat: popper improvements feat: popover improvements Mar 18, 2019
@MattL75 MattL75 self-assigned this Mar 18, 2019
@MattL75 MattL75 merged commit 0796dfa into master Mar 20, 2019
@MattL75 MattL75 deleted the feat/popper branch March 20, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@droshev droshev Awaiting requested review from droshev

@Algatron Algatron Awaiting requested review from Algatron

Assignees

@MattL75 MattL75

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MattL75 @mikerodonnell89 @InnaAtanasova