Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all instances of is[Component] inputs in the library #771

Closed
MattL75 opened this issue May 2, 2019 · 1 comment
Closed

Remove all instances of is[Component] inputs in the library #771

MattL75 opened this issue May 2, 2019 · 1 comment
Labels
bug Something isn't working code refactoring datepicker date picker related issues
Projects
board
Milestone
sprint 14 - Wun W...

Comments

@MattL75
Copy link
Contributor

MattL75 commented May 2, 2019 •
edited

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

This is very unclean. Let's remove it. There's a couple instances I can think of.

  • Popover's isDropdown. Can be solved by having an actual dropdown component.
  • Calendar's isDateTimePicker. Can be solved by making the keyboard logic more generic.
  • Time's isDateTimePicker. Doesn't seem to do anything?

More may be added if I find them.
@MattL75 MattL75 added bug Something isn't working code refactoring labels May 2, 2019
@JKMarkowski
Copy link
Contributor

Just FYI, I will take a look on it.

@JKMarkowski JKMarkowski mentioned this issue Jun 14, 2019
Closed
@droshev droshev added this to the sprint 13 - Hot Pie milestone Jun 14, 2019
@JKMarkowski JKMarkowski mentioned this issue Jun 17, 2019
Merged
@droshev droshev added this to To do in Development via automation Jun 20, 2019
@droshev droshev added the datepicker date picker related issues label Jun 20, 2019
@droshev droshev closed this as completed Jun 26, 2019
Development automation moved this from To do to Done Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working code refactoring datepicker date picker related issues
Projects
No open projects
board
  
Awaiting triage
Milestone
sprint 14 - Wun Weg Wun Dar Wun
Development

No branches or pull requests
3 participants
@droshev @MattL75 @JKMarkowski