fix: remove isComponent #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit a7a8d18 |
JKMarkowski
force-pushed
the
enhancement/#771-remove-is-component
branch
from
45aa590
to
3f91761
Compare
mikerodonnell89
requested changes
Jun 19, 2019
| * ``` | ||
| */ | ||
| @Component({ | ||
| selector: 'fd-dropdown', |
There was a problem hiding this comment.
Really like your solution here but I think this component would be better named fd-dropdown-control, like how we have fd-popover-control
mikerodonnell89
approved these changes
Jun 21, 2019
|
Note that we are also using isStatusLabel for the label component but we'll address that in another ticket here: #952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#771
Please provide a brief summary of this pull request.
I added popover-dropdown component and removed isDateTimePicker from time component,
changed input flag on calendar component to make it more clear.
If this is a new feature, have you updated the documentation?
I changed documentation due to dropdown changes.