fd-panel-grid class not properly updated after changing col attribute

[adamko147]

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

fd-panel-grid class value is not properly updated after changing [col] attribute

Which versions of Angular and Fundamental NGX are affected? (If this is a feature request, use current version.)

Angular 7.2.0
fiori-fundamentals: 1.5.7
fundamental-ngx: 0.5.1
using SCSS

If this is a bug, please provide steps for reproducing it.

fd-panel-grid with 4 columns, content in one column has "Hide" button.

when page is loaded

<fd-panel-grid class="fd-panel-grid--4col fd-panel-grid--nogap fd-panel-grid" ng-reflect-col="4" ng-reflect-nogap="true">

is generated. When clicking Hide button, change in the [col] property causes the grid is updated as

<fd-panel-grid class="fd-panel-grid--3col" ng-reflect-col="3" ng-reflect-nogap="true">

The updated class is missing fd-panel-grid--nogap fd-panel-grid classes so content of the grid is not properly organised (cols stack vertically instead of horizontally).

Please provide relevant source code if applicable.

• test.component.html

<fd-panel-grid [nogap]="true" [col]="col">
    <fd-panel *ngIf="showFirst">
        <button fd-button (click)="showFirst = false">Hide</button>
    </fd-panel>
    <fd-panel>Col 2</fd-panel>
    <fd-panel>Col 3</fd-panel>
    <fd-panel>Col 4</fd-panel>
</fd-panel-grid>

• test.component.ts

@Component({
    selector: 'app-test',
    templateUrl: './test.component.html',
    styleUrls: ['./test.component.scss']
})
export class TestComponent {
    showFirst: boolean = true;
    get col() {
        return this.showFirst ? 4: 3
    }
    constructor() { }
}

• test.component.scss

// empty

Is there anything else we should know?

setting style

<fd-panel-grid class="fd-panel-grid--nogap fd-panel-grid"> ... </fd-panel-grid>

solves the problem, however it's workaround.

[adamko147]

Can be caused by removing all classes in AbstractFdNgxClass.ngOnChanges https://github.com/SAP/fundamental-ngx/blob/master/library/src/lib/utils/abstract-fd-ngx-class.ts#L44 ?

[MattL75]

This should be fixed by @JKMarkowski's PR #881