fix: Add removed classes while changed on grid panel #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 693de03 |
MattL75
reviewed
Jun 10, 2019
| @@ -15,7 +15,7 @@ export class PanelGridComponent extends AbstractFdNgxClass { | |||
| @Input() | |||
| col: number; | |||
|
|
|||
| /** Whether the grid shoul have a gap. */ | |||
| /** Whether the grid should have a gap. */ | |||
| @Input() | |||
| @HostBinding('class.fd-panel-grid--nogap') | |||
There was a problem hiding this comment.
is there a point in keeping this line if we're just adding the class in setProperties?
There was a problem hiding this comment.
No, there is no point in adding classes in HostBinding.
mikerodonnell89
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#864
Please provide a brief summary of this pull request.
In issue there is noticed that, basic fd-grid-panel classes dissapear, when number of columns is changed
If this is a new feature, have you updated the documentation?
Not needed.