Defect Hunting Sprint 107

[InnaAtanasova]

Please list the issues you've found during the defect hunting.

[mikerodonnell89]

A handful of #9225 still need some work:

• Dialog @g-cheishvili - in ui5, upon opening the dialog, the confirm/submit/approve/etc button is focused rather than ours, which defaults to the cancel button. Open the first example here: https://sapui5.hana.ondemand.com/#/entity/sap.m.Dialog/sample/sap.m.sample.DialogConfirm
  fix(docs): core dialog examples initial focus targets #9434

• Dialog with inner popovers @g-cheishvili - the left and right borders of these inputs are not visible when the mouse is hovering them
  - created new issue in styles Scrollbar and form items in horizon fundamental-styles#4276
  fix(core): fixed dialog body redundant elements #9435

• Inline help custom color CSS not working @g-cheishvili

SAP/fundamental-styles#4282

• Menu with scrollbar @g-cheishvili :

• Multicombobox grows horizontally when options are selected. Should the examples be utilizing some max-width? @N1XUS - fix(docs): beautify multi combobox docs #9422

• Large object status, bottom of icons extends beyond the rest of the block @N1XUS - fix(styles): refactor object status component [ci visual] fundamental-styles#4271

• Margin under select changes when popover open @N1XUS - fix(styles): form input correct margins [ci visual] fundamental-styles#4272

Screen.Recording.2023-01-23.at.3.25.33.PM.mov

• Core side nav docs - We have 2 "Link 3"'s here in this example and the first one is missing its border-bottom

[droshev]

• platform table with toolbar @platon-rov - https://fundamental-ngx.netlify.app/#/platform/table make the toolbar with overflow
• column resize styling issue (not covering whole height) @platon-rov

• compact platform table > grouping by multiple columns dialog selects focus is cut @N1XUS - fix(styles): form input correct margins [ci visual] fundamental-styles#4272

• platform table > grouping by multiple columns dialog select is jumping @N1XUS - fix(styles): form input correct margins [ci visual] fundamental-styles#4272
  

• platform table no outer border has right border @platon-rov

• platform table Custom component to render "No data" message no border in RTL - @platon-rov

• Menu in platform cut border after being open @g-cheishvili

#9436

[mikerodonnell89]

All on Core:

• Action sheet - clicking the control button when the action sheet is already open does not close it. This is not the case with menu, popover, etc

• Avatar group, group type example, there are certain parts of the overflow button you can click that won't open the popover fix(styles): avatar group control height bug fundamental-styles#4275

• List - sometimes pressing shift+tab to focus the element before the list doesn't work. Doesn't always happen

• List - mouse click the 5th item in the list to focus it. Then press shift+tab. This moves the focus to the first item in the list. Press shift - this moves the focus back to the 5th item

• Multi-combobox - cannot navigate to or select items from the popover list via keyboard only

• Compact select, control button focus - cannot see the top and bottom sides of the focus box.
  compact:

here it is looking good in cozy mode

[mikerodonnell89]

• Platform smart filter bar docs page automatically scrolls to this example

[mikerodonnell89]

Both core and platform table docs pages take a noticeably longer time to load than all other pages

[mikerodonnell89]

Platform multi input, "Multi Input With Value help dialog box with complex Objects object" example:

• when I first open the complex popover, only the state text displays. The secondary text displays on subsequent popover closes/opens. Before:

After:

• incorrect example code

[mikerodonnell89]

• Platform Search field popover items missing focus radius