Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): form input correct margins [ci visual] #4272

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Feb 21, 2023

Related Issue

Fixes SAP/fundamental-ngx#9228

Description

  • Fixed input-group (and it's descendants) examples to reflect correct compact state;
  • Fixed select margin bottom issue @InnaAtanasova style specs does not reflect on removing bottom margin. Popover should be adjusted accordingly to the element margin instead;

BREAKING CHANGE:
Compact input group should have .fd-input-group--compact class to apply new margins.

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • All values are in rem
  • Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

@N1XUS N1XUS added Bug Something isn't working Defect Hunting labels Feb 21, 2023
@N1XUS N1XUS added this to the Sprint 107 milestone Feb 21, 2023
@N1XUS N1XUS requested a review from a team February 21, 2023 11:16
@N1XUS N1XUS self-assigned this Feb 21, 2023
@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 6e26f47
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/63f4a9d1c6fdce0008f79e15
😎 Deploy Preview https://deploy-preview-4272--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@N1XUS N1XUS force-pushed the fix/9228-form-input-margins branch from 9a16b07 to 6e26f47 Compare February 21, 2023 11:23
@N1XUS N1XUS merged commit 01e1bc6 into main Feb 22, 2023
@N1XUS N1XUS deleted the fix/9228-form-input-margins branch February 22, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Defect Hunting
Projects
Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Defect Hunting Sprint 107
2 participants