Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combobox primary button click #1165

Merged
merged 2 commits into from Aug 23, 2019

Conversation

JKMarkowski
Copy link
Contributor

Please provide a link to the associated issue.

fixes: #1139

Please provide a brief summary of this pull request.

I added search function call on primary button click.

If this is a new feature, have you updated the documentation?

@netlify
Copy link

netlify bot commented Aug 23, 2019

Deploy preview for fundamental-ngx ready!

Built with commit 17017e9

https://deploy-preview-1165--fundamental-ngx.netlify.com

@InnaAtanasova
Copy link
Contributor

Can we add an example in the documentation with this specific case? Like providing a searchFunction and the button is not the arrow but the Search icon? Let me know what you think about it @droshev @JKMarkowski
Apart from this the code looks great!

@JKMarkowski
Copy link
Contributor Author

Sure, I will add example to this PR

@JKMarkowski JKMarkowski merged commit 0ad23e9 into master Aug 23, 2019
@JKMarkowski JKMarkowski deleted the fix/#1139-combobox-event-emitter branch August 23, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox - Emit event when button icon is clicked
3 participants