fix: Modal height example issues. Close icon fix. #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght. Fix close icon
|
Deploy preview for fundamental-ngx ready! Built with commit 5c9a494 |
MattL75
reviewed
Oct 25, 2019
| if (!elementRef) { | ||
| return; | ||
| } | ||
| this.HOST_COMPONENT_CLASS_LIST.forEach(className => elementRef.nativeElement.classList.add(className)); |
There was a problem hiding this comment.
Maybe consider using?
elementRef.nativeElement.classList.add(...this.HOST_COMPONENT_CLASS_LIST);
There was a problem hiding this comment.
Actually, your example looks better.
droshev
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes: #1474
Please provide a brief summary of this pull request.
I changed the way how there are added classes, when modal is generated
as component. There is also fixedmax-heightvalue for whole modal.I added some classes to the icon element, following fundamental-styles.
If this is a new feature, have you updated the documentation?
There is changed example a little bit, with height specified.
README.md