Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changed glyph for stackblitz #1487

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Conversation

stefanoScalzo
Copy link
Contributor

Please provide a link to the associated issue.

fixes: #1478

Please provide a brief summary of this pull request.

Change the icon of the stackblitz and keep the appropriate styling

@netlify
Copy link

netlify bot commented Oct 25, 2019

Deploy preview for fundamental-ngx ready!

Built with commit 1330e7c

https://deploy-preview-1487--fundamental-ngx.netlify.com

@@ -15,7 +15,7 @@
</button>
<button
fd-button
glyph="copy"
glyph="play"
title="Copy example to clipboard"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make the title 'Open example on Stackblitz' or something?

Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good once the title is being updated

@droshev droshev added the documentation There is an issue with documentation label Oct 25, 2019
@droshev droshev added this to In progress in Development via automation Oct 25, 2019
@droshev droshev added this to the sprint 22 - Gendry milestone Oct 25, 2019
@stefanoScalzo stefanoScalzo merged commit ed32982 into master Oct 28, 2019
Development automation moved this from In progress to Done Oct 28, 2019
@stefanoScalzo stefanoScalzo deleted the fix/ux-styling-stackblitz branch October 28, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation There is an issue with documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Stackblitz button ux problems
3 participants