docs: (platform) added stackBlitz url for button example files #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 276b706 |
|
Deploy preview for fundamental-ngx ready! Built with commit d20f2ad |
JKMarkowski
suggested changes
Oct 29, 2019
| @@ -131,7 +133,11 @@ export class CodeExampleComponent implements OnInit, AfterViewInit { | |||
| this.exampleFiles.forEach(example => { | |||
|
|
|||
| if (example.fileName && example.component) { | |||
| this.parameters.html_tag = 'fd-' + example.fileName; | |||
|
|
|||
| if (example.fileName !== undefined && example.fileName.indexOf('platform') !== -1) { this.parameters.html_tag = 'fdp-' + example.fileName; } | |||
There was a problem hiding this comment.
Try to keep
if () {
} else {
}
structure of statements.
|
We should also stop depending on string containing |
JKMarkowski
approved these changes
Oct 29, 2019
InnaAtanasova
changed the title
sKudum
force-pushed
the
sushma/stackbliz
branch
from
7a38db1
to
d20f2ad
Compare
fkolar
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Please provide a brief summary of this pull request.
added stackBlitz url for button example files
If this is a new feature, have you updated the documentation?
yes
README.md