fix: (core) Introduce change detection strategy OnPush #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKMarkowski
force-pushed
the
fix/#780-detection-strategy-onpush
branch
from
4f13e6d
to
78bc46e
Compare
|
Deploy preview for fundamental-ngx ready! Built with commit 4f13e6d |
JKMarkowski
force-pushed
the
fix/#780-detection-strategy-onpush
branch
from
78bc46e
to
6d650b2
Compare
|
Deploy preview for fundamental-ngx ready! Built with commit 78bc46e |
|
Deploy preview for fundamental-ngx ready! Built with commit b6660bf |
JKMarkowski
requested review from
InnaAtanasova,
droshev,
stefanoScalzo and
fkolar
JKMarkowski
changed the title
JKMarkowski
force-pushed
the
fix/#780-detection-strategy-onpush
branch
from
ed2dbd7
to
c4b444a
Compare
JKMarkowski
force-pushed
the
fix/#780-detection-strategy-onpush
branch
from
c4b444a
to
e6ff963
Compare
JKMarkowski
force-pushed
the
fix/#780-detection-strategy-onpush
branch
from
e6ff963
to
c6a6dcf
Compare
MattL75
reviewed
Oct 29, 2019
| this.calendarI18nLabels.labelsChange | ||
| .pipe(takeUntil(this.onDestroy$)) | ||
| .subscribe(() => this.changeDetRef.markForCheck()) | ||
| ; |
There was a problem hiding this comment.
Consider merging these observables to avoid repeated code
droshev
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes: #780
fixes: #1399
Please provide a brief summary of this pull request.
There is added
OnPushchange detection strategy. It will cause great performance improvement.I had to add 2 rxjs subjects for i18n services on calendar, to trigger change detection.
If this is a new feature, have you updated the documentation?
README.md