fix: (core) added selected button with group #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 21d91f2 |
stefanoScalzo
force-pushed
the
feat/button-group-selected
branch
from
60801a4
to
3560243
Compare
|
from the changes I see, this is not just docs change |
stefanoScalzo
changed the title
Changed! |
|
@stefanoScalzo Can you add some description on the button group examples - the 2 use cases we support? |
JKMarkowski
reviewed
Nov 12, 2019
| this.calendarI18n.i18nChange.next(); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Do we need to add this file ?
| this.calendarI18nLabels.labelsChange.next(); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Do we need to add this file ?
| } | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Do we need to add this file ?
There was a problem hiding this comment.
they shouldnt be there ill remove them
|
Hi @stefanoScalzo could you try to rebase this branch to |
stefanoScalzo
force-pushed
the
feat/button-group-selected
branch
from
7f926d3
to
36b5ba4
Compare
stefanoScalzo
force-pushed
the
feat/button-group-selected
branch
from
36b5ba4
to
21d91f2
Compare
droshev
approved these changes
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes:#1542
fixes: #1211
Please provide a brief summary of this pull request.
Allow the button group to have one option selected and toggle as each button gets clicked
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist: