feat:(core) Introduction of Angular DatePipe #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKMarkowski
changed the title
|
Deploy preview for fundamental-ngx ready! Built with commit ab050d7 |
|
@JKMarkowski is this just a POC or a PR for merging? |
JKMarkowski
changed the title
JKMarkowski
changed the title
|
@droshev I think we can treat it like normal PR. |
JKMarkowski
force-pushed
the
exp/ng-pipe-datepicker
branch
from
6f91b0d
to
8fe2c89
Compare
stefanoScalzo
approved these changes
Nov 19, 2019
InnaAtanasova
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes: #1388
Please provide a brief summary of this pull request.
There is added angular's date pipe, which took responsibility of formatting Date models to string.
It has no compact on default formatting/parsing, default format is the same as before.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md