fix: (core) Add popover new open shortcut, improve multi input keyboard support, fix visual menu focus #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKMarkowski
commented
Nov 13, 2019
| @@ -12,7 +12,6 @@ | |||
| <fd-multi-input | |||
| formControlName="disabledSelectedValues" | |||
| [dropdownValues]="['Apple', 'Banana', 'Pineapple', 'Tomato']" | |||
| [disabled]="'true'" | |||
There was a problem hiding this comment.
Disabled state is added in typescript file. It caused some console warnings.
JKMarkowski
commented
Nov 13, 2019
| @@ -9,7 +9,6 @@ | |||
| [attr.aria-expanded]="this.disabled ? false : isOpen" | |||
| [attr.aria-disabled]="this.disabled" | |||
| aria-haspopup="true" | |||
| [disabled]="disabled" | |||
There was a problem hiding this comment.
Duplicated [disabled]
JKMarkowski
force-pushed
the
fix/#911-keyboard-support
branch
from
d578f54
to
b4d856a
Compare
JKMarkowski
changed the title
|
Deploy preview for fundamental-ngx ready! Built with commit e2540b4 |
JKMarkowski
force-pushed
the
fix/#911-keyboard-support
branch
from
b4d856a
to
0d93b7d
Compare
JKMarkowski
force-pushed
the
fix/#911-keyboard-support
branch
from
0d93b7d
to
e2540b4
Compare
JKMarkowski
commented
Nov 14, 2019
| clickHandler(event) { | ||
| event.stopPropagation(); | ||
| if (!this.elRef.nativeElement.contains(event.target)) { | ||
| this.isOpen = false; |
There was a problem hiding this comment.
Popover provides this functionality, it's not needed anymore
JKMarkowski
changed the title
JKMarkowski
changed the title
InnaAtanasova
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes: #911
Please provide a brief summary of this pull request.
I added
alt + ArrowDownsupport for popovers components. Also I improved a little multi input keyboard support, Now it's possible to navigate by arrows. There was some leftover after fundamental-styles 0.2.0 adapation, which is remvoed.Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md