fix: (core) Add shellbar side navigation example and directive. #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKMarkowski
changed the title
|
Deploy preview for fundamental-ngx ready! Built with commit 1f77020 |
JKMarkowski
force-pushed
the
fix/347-side-nav
branch
from
2235276
to
c8f1bc6
Compare
droshev
added
core
|
@JKMarkowski can you move |
droshev
requested changes
Nov 17, 2019
There was a problem hiding this comment.
@JKMarkowski can you update the product switch examples? Also the hamburger menu doesn't look like per specification
JKMarkowski
changed the title
|
Now, the 3rd levels are removed completely. |
|
The Hamburger menu is still with light blue background |
|
Hi @InnaAtanasova, the button is with white background only on hover, shouldn't it be like that ? |
It should look like the Product Switch button |
JKMarkowski
force-pushed
the
fix/347-side-nav
branch
from
305b094
to
60e2488
Compare
|
Hi @InnaAtanasova, it fully follows product-switch control button now. |
InnaAtanasova
approved these changes
Nov 22, 2019
droshev
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes: #347
Please provide a brief summary of this pull request.
There is added side navigation directive on shellbar and 1 example of usage.
Also I removed information about side navigation up to 10 levels usage.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md