fix: (core) DatePicker - fix form's valid flag, when allowNull #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 7d0fe76 |
|
@JKMarkowski can you put |
JKMarkowski
changed the title
stefanoScalzo
approved these changes
Nov 19, 2019
| * 0, when none, | ||
| * 1, when only startDate, or endDate same as startDate, | ||
| * 2, when both | ||
| * 0, when none of selected, or start date is invalid, |
There was a problem hiding this comment.
My English is not good, but doesn't this mean exactly the same as point 2? (both are valid)
@stefanoScalzo some help here?
There was a problem hiding this comment.
should be
0, when selected and startDate are valid
1, when given valid startDate and endDate is same as startDate
There was a problem hiding this comment.
It has been changed, please take a look on it now.
InnaAtanasova
approved these changes
Nov 19, 2019
| * 1, when only startDate, or endDate same as startDate, | ||
| * 2, when both | ||
| * 0, when none of selected, or start date is invalid, | ||
| * 1, when only startDate, or endDate same as startDate, but startDate is valid, |
There was a problem hiding this comment.
And here I am lost ...
There was a problem hiding this comment.
It has been changed :)
JKMarkowski
changed the title
JKMarkowski
force-pushed
the
fix/#1598-datepicker-allownull
branch
from
8d4bc05
to
ab41b6c
Compare
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes: #1598
Please provide a brief summary of this pull request.
Right now I check if the input is empty and allowNull flag is added. Also there was some minor bug on datepicker, which is fixed now.
Please check whether the PR fulfills the following requirements
This is only fix PR, without any new things. So no docs needs to be changed.
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md